Implement SIGN() #164
Closed
Implement SIGN() #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhatcher
requested changes
Dec 8, 2024
Member
nhatcher
left a comment
nhatcher
left a comment
There was a problem hiding this comment.
Hi @sylvinus , this is great!
You need to add a test file (created by Excel) in:
https://github.com/ironcalc/IronCalc/tree/main/xlsx/tests/calc_tests
It should cover the happy paths and some of the errors. See, for instance the function ABS.xlsx note how cells with a formula are formatted differently
Member
|
Hi @sylvinus , this is done otherwise is some open PRs. Since this has been open too long will close for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I tried to implement a very simple function :-)
Let me know if I missed anything!
Thanks,